Add ServerCredentials - #7601
Merged
Merged
Conversation
sanjaypujare
reviewed
Nov 9, 2020
sanjaypujare
reviewed
Nov 9, 2020
sanjaypujare
reviewed
Nov 9, 2020
Member
Author
|
Closed+reopened to trigger CLA check. |
sanjaypujare
reviewed
Nov 9, 2020
sanjaypujare
approved these changes
Nov 13, 2020
sanjaypujare
left a comment
Contributor
There was a problem hiding this comment.
LGTM with a comment about replacing "TODO" with the actual issue number in the experimentalApi annotation
ejona86
force-pushed
the
server-credentials
branch
from
November 13, 2020 16:59
01b9919 to
c0137cc
Compare
Member
Author
|
I've fixed the TODO links and squashed commits appropriately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very similar to the ChannelCredentials, except easier all around. The changes are split up similar to before, and most of it should feel very familiar.